feat: add new radio text event #742
Conversation
Steinertech9
added
documentation
Steinertech9
force-pushed
the
dev/735-new-event-type-deardeventhubv1radiotext-for-possible-encoder-integration
branch
from
4259fd3 to
e19a1aa
Compare
|
Could you also add example messages from #735 like at https://swrlab.github.io/ard-eventhub/#/docs/TYPES (which we probably also link in https://swrlab.github.io/ard-eventhub/#/docs/EVENTS) |
There was a problem hiding this comment.
and we should add a full POST example to the docs as @saerdnaer suggested (#742 (comment))
also, we could use 1.10.0 as version
openapi.yaml
Outdated
| The subset is defined in the list of required fields of Schemas `eventV1PostRadioTextBody`, resulting in this body: | ||
| ```json | ||
| { | ||
| "event": "music", |
There was a problem hiding this comment.
event should be de.ard.eventhub.v1.radio.text
| { | ||
| "event": "music", | ||
| "start": "2020-01-19T06:00:00+01:00", | ||
| "validUntil": "2026-01-19T06:00:00+01:00", |
There was a problem hiding this comment.
validUntil example should be greater than start?
src/utils/events/processServices.js
Outdated
|
|
||
| // add a different suffix for radio text topics to not confuse subscribers with new event | ||
| if (req.body.event === 'de.ard.eventhub.v1.radio.text') { | ||
| urnPrefix = `RadioText:${urnPrefix}` |
There was a problem hiding this comment.
this breaks the otherweise fairly lowercase spelling
{"id":"RadioText:urn:ard:permanent-livestream:a315d3e482f09e1b","messageId":"13323640311135945","name":"de.ard.eventhub.dev.RadioText%3Aurn%3Aard%3Apermanent-livestream%3Aa315d3e482f09e1b","status":"MESSAGE_SENT"}
maybe radio-text?
…ext-for-possible-encoder-integration
adds a new event for changing the live encoder for radio